[Asterisk-code-review] chan_pjsip: Add option for moh allows only answered channel (asterisk[master])

[sungtae kim]

Attention is currently required from: N A.
sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18781 )

Change subject: chan_pjsip: Add option for moh allows only answered channel
......................................................................


Patch Set 4:

(5 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/ba4156ef_85840cbd 
PS4, Line 7: chan_pjsip: Add option for moh allows only answered channel
> This title is unclear to me. It sounds like this option ignores hold if the channel is unanswered. […]
Good point. Fixed it. :)


https://gerrit.asterisk.org/c/asterisk/+/18781/comment/9c5efe14_2d63e79c 
PS4, Line 11: 
> I don't follow the description. […]
No objection. Fixed it. :)


Patchset:

PS4: 
Hi @InterLinked,

Thanks a lot! :) I fixed it all.


File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/d08e5dc2_71b1d98d 
PS4, Line 1771: 			ast_log(LOG_DEBUG, "The session '%s' is not able to oh hold with endpoint '%s'.\n",
> 1. I think you have a typo here, extraneous "oh"? […]
Nice catch. Fixed it.


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/f86292ce_7d778400 
PS4, Line 678: ;moh_answeredonly=yes   ; Allows the only answered channel able to be music on hold.
> This phrasing is unclear to me and a casual reader would not understand this. […]
Very clear. :) Fixed it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3c9b9101e4dc85338154b8004cecdd3edc227474
Gerrit-Change-Number: 18781
Gerrit-PatchSet: 4
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 13 Jul 2022 03:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220712/4aef8a8a/attachment.html>