[Asterisk-code-review] test: Add coverage for res_crypto (asterisk[master])

[N A]

Attention is currently required from: Philip Prindeville.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18532 )

Change subject: test: Add coverage for res_crypto
......................................................................


Patch Set 13: Code-Review-1

(4 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18532/comment/cbcfd072_de8c97cc 
PS13, Line 8: 
What is being tested exactly?


File tests/test_crypto.c:

https://gerrit.asterisk.org/c/asterisk/+/18532/comment/ba90a8d2_1d06a530 
PS13, Line 4:  * Copyright (C) 2022, Digium, Inc.
The copyright is yours, not Digium's.


https://gerrit.asterisk.org/c/asterisk/+/18532/comment/b48f3a50_37b8cc5d 
PS13, Line 107: 	strcat(key_dir, "/tests/keys");
Seems like if getcwd got key_dir filled all the way up, strcat could write past the end. Should we use strncat or is this guaranteed to be safe?


https://gerrit.asterisk.org/c/asterisk/+/18532/comment/a42c12e4_4ecf25c3 
PS13, Line 118: 	if (key == NULL) {
could also be !key

Same 2 comments about the rest of the file where these appear



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18532
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0d10e7b41009c5290a4356c6480e636712d5c96d
Gerrit-Change-Number: 18532
Gerrit-PatchSet: 13
Gerrit-Owner: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Philip Prindeville <philipp at redfish-solutions.com>
Gerrit-Comment-Date: Tue, 12 Jul 2022 16:38:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220712/6864da53/attachment.html>