[Asterisk-code-review] res_prometheus.c: missing module dependensy (asterisk[18])

N A asteriskteam at digium.com
Fri Jan 28 15:47:36 CST 2022


Attention is currently required from: Mark Petersen.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17913 )

Change subject: res_prometheus.c: missing module dependensy
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17913/comment/ee9e6c8f_dc441580 
PS1, Line 7: res_prometheus.c: missing module dependensy
dependensy is spelled wrong


https://gerrit.asterisk.org/c/asterisk/+/17913/comment/ac7e5246_da652f45 
PS1, Line 11: 
This is a bit unclear to me.
Did line 1 effect line 2, or are these two separate things listed as what the commit does?

E.g. added option *which* fixes issue or added option *and* fixes issue?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17913
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ia0f49d048427a40e1b763296b834a52a03610096
Gerrit-Change-Number: 17913
Gerrit-PatchSet: 1
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Fri, 28 Jan 2022 21:47:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220128/1a116a5c/attachment.html>


More information about the asterisk-code-review mailing list