[Asterisk-code-review] app_queue: load queues and members from Realtime when needed (asterisk[16])
N A
asteriskteam at digium.com
Fri Jan 21 15:30:50 CST 2022
Attention is currently required from: Alexei Gradinari.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17918 )
Change subject: app_queue: load queues and members from Realtime when needed
......................................................................
Patch Set 1: Code-Review-1
(4 comments)
Commit Message:
https://gerrit.asterisk.org/c/asterisk/+/17918/comment/2712af2f_2d205991
PS1, Line 10: which do not load queue and queue's members from Realtime.
queue's members -> queue members
https://gerrit.asterisk.org/c/asterisk/+/17918/comment/e264cc33_9f69586a
PS1, Line 23: which load queue and queue's members for desired queue
which loads queue and queue members
https://gerrit.asterisk.org/c/asterisk/+/17918/comment/e819b9e1_3ea320d8
PS1, Line 32: warning
is not an error to warn about.
Patchset:
PS1:
Not to nit pick, but a few grammar issues here which would improve clarity if fixed.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17918
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I554ee0eebde93bd8f49df7f84b74acb21edcb99c
Gerrit-Change-Number: 17918
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Fri, 21 Jan 2022 21:30:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220121/29af7ba6/attachment.html>
More information about the asterisk-code-review
mailing list