[Asterisk-code-review] pbx: Ensure we don't operate on dialplan while dialplan is reloading, ... (asterisk[18])

[Mark Murawski]

Attention is currently required from: Sean Bright, Joshua Colp, Kevin Harwell.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17798 )

Change subject: pbx: Ensure we don't operate on dialplan while dialplan is reloading, which causes deadlocks
......................................................................


Patch Set 5:

(4 comments)

Patchset:

PS4: 
> The idea of the trylock was to check if the reload is pending. […]
There's also additional sources of deadlocks... if pjsip is using:
has_hint + hint_exten, this deadlock triggers fairly regularly.


File include/asterisk/module.h:

https://gerrit.asterisk.org/c/asterisk/+/17798/comment/1220f92d_dd3dc3a6 
PS4, Line 181: enum ast_module_reload_result ast_module_reload_pending_check(void);
> This needs to be documented.
Done


File include/asterisk/pbx.h:

https://gerrit.asterisk.org/c/asterisk/+/17798/comment/eddf6992_0369e2d4 
PS4, Line 1072:  * \brief Try and get a read lock the context list
> on the context list
Done


File main/loader.c:

https://gerrit.asterisk.org/c/asterisk/+/17798/comment/6f45a2e2_97925c23 
PS4, Line 1571: 		ast_verb(3, "The previous reload command didn't finish yet\n");
> This is an API call to check something, by itself it should not generate a verbose message. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17798
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I435db97fc56f18b6f5c25a3e400603817b07aa49
Gerrit-Change-Number: 17798
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 18 Jan 2022 02:24:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220117/33da8424/attachment.html>