[Asterisk-code-review] pbx: Ensure we don't operate on dialplan while dialplan is reloading, ... (asterisk[18])

[Sean Bright]

Attention is currently required from: Mark Murawski.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17798 )

Change subject: pbx: Ensure we don't operate on dialplan while dialplan is reloading, which causes deadlocks
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
> I don't see any legitimate reason that 'dialplan reload' should continually lock up dialplan and reload asterisk.  There is also an easily trigger-able deadlock that needs to be fixed and gracefully bailing from reloads and adds while dialplan is reloading makes I think makes a lot of sense.

No one is arguing any of this and the problem is very well documented on the accompanying issue. Obviously a fix is needed, but this problem is not a new one that we have to rush to fix. I also have a general aversion to adding public API because it is 'quick.'

There are places other than the CLI handlers that call ast_add_extension(...) - how does this change prevent deadlock in this cases?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17798
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I435db97fc56f18b6f5c25a3e400603817b07aa49
Gerrit-Change-Number: 17798
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Mon, 17 Jan 2022 21:39:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220117/76056ca2/attachment.html>