[Asterisk-code-review] res_pjsip_outbound_registration: Show time until expiration (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17789 )

Change subject: res_pjsip_outbound_registration: Show time until expiration
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/17789/comment/437a9f6f_2c5747a8 
PS1, Line 2291: 		state ? " (exp. " : "", state->client_state->registration_expires - ((int) time(NULL)), state ? "s)" : "");
Actually, this can end up becoming negative if the remote side isn't responding which can be confusing from a user perspective. I think the output should make it clearer what is happening in that case.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17789
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic4fea15a1a1056c424416def49d1ca8e776c0483
Gerrit-Change-Number: 17789
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 12 Jan 2022 14:27:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220112/f3acfd16/attachment.html>