[Asterisk-code-review] Do not change 180 Ringing to 183 Progress even if early_media already... (asterisk[16])

N A asteriskteam at digium.com
Fri Jan 7 11:16:34 CST 2022


Attention is currently required from: Mark Petersen.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17785 )

Change subject: Do not change 180 Ringing to 183 Progress even if early_media already enabled
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

Patchset:

PS4: 
The commit message should start with the name of the module, chan_sip, in this case.

e.g. chan_sip: Do not change 180 Ringing to 183 Progress even if early media already enabled

It also wraps onto a second line at the moment so you may want to address that.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17785
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
Gerrit-Change-Number: 17785
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Fri, 07 Jan 2022 17:16:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220107/7c6aaab3/attachment.html>


More information about the asterisk-code-review mailing list