[Asterisk-code-review] chan_sip.c Enable pickup on channel that are in AST_STATE_DOWN (asterisk[16])

Mark Petersen asteriskteam at digium.com
Fri Jan 7 04:06:21 CST 2022


Attention is currently required from: Joshua Colp.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17782 )

Change subject: chan_sip.c Enable pickup on channel that are in AST_STATE_DOWN
......................................................................


Patch Set 3:

(1 comment)

File channels/chan_sip.c:

https://gerrit.asterisk.org/c/asterisk/+/17782/comment/bf3bb009_5b9e50b4 
PS1, Line 24221: 				ast_setstate(p->owner, AST_STATE_RINGING);
> Yes, there is no quick solution for this.
found a different way to fix the problem by doing the same as done in
main/pickup.c ast_can_pickup()



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17782
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4c7d223870f8ce9a7354e0f73d4e4cb2e8b58841
Gerrit-Change-Number: 17782
Gerrit-PatchSet: 3
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 07 Jan 2022 10:06:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220107/878201ac/attachment.html>


More information about the asterisk-code-review mailing list