[Asterisk-code-review] chan_sip.c: Enable pickup on channel after having received 183 Progress (asterisk[16])

[Joshua Colp]

Attention is currently required from: Mark Petersen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17782 )

Change subject: chan_sip.c: Enable pickup on channel after having received 183 Progress
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File channels/chan_sip.c:

https://gerrit.asterisk.org/c/asterisk/+/17782/comment/8acd3cfd_c9675cfe 
PS1, Line 24221: 				ast_setstate(p->owner, AST_STATE_RINGING);
I'm not comfortable with this change as it fundamentally alters the behavior for 183 in chan_sip, and we don't know the full ramifications of it. This will change AMI events for example.

Is there other precedent for doing this? I don't believe anything else does this.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17782
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I4c7d223870f8ce9a7354e0f73d4e4cb2e8b58841
Gerrit-Change-Number: 17782
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Tue, 04 Jan 2022 11:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220104/c55858e7/attachment.html>