[Asterisk-code-review] various: fix and test a double deref on a scheduled delete of an exec... (asterisk[16])

[Joshua Colp]

Attention is currently required from: Michael Bradeen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17644 )

Change subject: various: fix and test a double deref on a scheduled delete of an executing call back.
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

File main/sched.c:

https://gerrit.asterisk.org/c/asterisk/+/17644/comment/20b8d209_8f76606a 
PS6, Line 623:  * schedule the relase.
release


File tests/test_sched.c:

https://gerrit.asterisk.org/c/asterisk/+/17644/comment/a7ba87c3_51742907 
PS6, Line 426: 		while(!ao2_ref(obj, -1));
The ao2_ref function returns the current reference count before the operation, so this isn't correct. I think you want it to loop while the return value is "> 1".



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17644
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Icfb16b3acbc29cf5b4cef74183f7531caaefe21d
Gerrit-Change-Number: 17644
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 04 Jan 2022 11:28:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220104/67fd096d/attachment-0001.html>