[Asterisk-code-review] chan_pjsip.c: allow_180_ringing_with_sdp (asterisk[16])

[Mark Petersen]

Attention is currently required from: Joshua Colp, N A, Alexei Gradinari, Mark Petersen.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17785 )

Change subject: chan_pjsip.c: allow_180_ringing_with_sdp
......................................................................


Patch Set 11:

(3 comments)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/17785/comment/b573c422_d14236fb 
PS9, Line 1626: 				if(ast_sip_get_allow_180_ringing_with_sdp()) {
> if (ast_sip
Ack


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/17785/comment/5674edb6_ef558aaf 
PS9, Line 1259: ;allow_180_ringing_with_sdp=yes	; preserve 180 Ringing after reciving an 183 with SDP
> I think this is confusing as described, because you're talking about receiving when in reality this  […]
Ack


File doc/CHANGES-staging/chan_pjsip_180_sdp.txt:

https://gerrit.asterisk.org/c/asterisk/+/17785/comment/00c38b19_a847f965 
PS9, Line 3: added new global config option "allow_180_ringing_with_sdp"
> My comment applies here as well.
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17785
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
Gerrit-Change-Number: 17785
Gerrit-PatchSet: 11
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Thu, 24 Feb 2022 14:42:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220224/ea7d88f6/attachment-0001.html>