[Asterisk-code-review] app_queue: Add QueueWithdrawCaller AMI action (asterisk[16])

[Kfir Itzhak]

Attention is currently required from: Kevin Harwell.
Kfir Itzhak has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18008 )

Change subject: app_queue: Add QueueWithdrawCaller AMI action
......................................................................


Patch Set 8:

(2 comments)

Patchset:

PS8: 
Resolved


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/18008/comment/861906ea_ff617440 
PS7, Line 7701: 	return res;
> You have a reference leak here on "q". queue_unref(q) needs to be called before returning.
Nice find, thank you.
I pretty much copied the code from change_priority_caller_on_queue, so that has to be fixed there as well.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18008
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic15aa238e23b2884abdcaadff2fda7679e29b7ec
Gerrit-Change-Number: 18008
Gerrit-PatchSet: 8
Gerrit-Owner: Kfir Itzhak <mastertheknife at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 24 Feb 2022 13:56:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220224/f2c8eca4/attachment.html>