[Asterisk-code-review] Makefile: Allow XML documentation to exist outside source files (asterisk[16])

[George Joseph]

Attention is currently required from: Michael Bradeen, Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18014 )

Change subject: Makefile: Allow XML documentation to exist outside source files
......................................................................


Patch Set 4:

(8 comments)

File build_tools/get_sourceable_makeopts:

https://gerrit.asterisk.org/c/asterisk/+/18014/comment/689944c9_c2d523d3 
PS3, Line 11: 		
> > redness […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/fde49c25_c4a0a034 
PS3, Line 15: 		
> redness
Done


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/e1c8cf81_2dbaec21 
PS3, Line 18: 		
> redness
Done


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/dbe258b4_f7b946ee 
PS3, Line 20: 		constructs.  It should be runnable by any shell. 
> More whitespace at eol.
Done


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/a458f8fc_00c5ad27 
PS3, Line 36: # We don't WANT the variables evaluated. 
> More whitespace.
Done


File build_tools/make_xml_documentation:

https://gerrit.asterisk.org/c/asterisk/+/18014/comment/490112ac_5d955fcf 
PS3, Line 26: 	
> redness
Done


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/74ddbbbb_d8e6642f 
PS3, Line 36: 	                  <output-file> and <core-output-file>. 
> extra space at eol.
Done


https://gerrit.asterisk.org/c/asterisk/+/18014/comment/9069bdf8_4a34d802 
PS3, Line 40: 	
> redness
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18014
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I486c16c0b5a44d7a8870008e10c941fb19b71ade
Gerrit-Change-Number: 18014
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 22 Feb 2022 18:07:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220222/94f36833/attachment-0001.html>