[Asterisk-code-review] func_groupcount.c: Adding Group Variables and additional Group functions (asterisk[18])

[N A]

Attention is currently required from: Sean Bright, Mark Murawski.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17655 )

Change subject: func_groupcount.c: Adding Group Variables and additional Group functions
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

Patchset:

PS7: 
You're probably aware of this, but FYI:

 cli.c:1906:2: error: expected specifier-qualifier-list before 'AST_DLLIST_ENTRY'
   AST_DLLIST_ENTRY(group_list_entry) entries;    /*!< Next group */
   ^

Also, another quick note on missing documentation:


File funcs/func_groupcount.c:

https://gerrit.asterisk.org/c/asterisk/+/17655/comment/12d7c900_a4102807 
PS7, Line 168: 				For more information, see the dialplan function GROUP_VAR().
I don't see the documentation for the GROUP_VAR function itself anywhere - kind of the most important one ;)
Additionally, this should be included in the see-also XML documentation for relevant AMI docs, etc., and vice versa.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17655
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I23e48d1cdfc8adaffdfec2e936e56143603914f2
Gerrit-Change-Number: 17655
Gerrit-PatchSet: 7
Gerrit-Owner: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Tue, 22 Feb 2022 01:13:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220221/c920cf2e/attachment.html>