[Asterisk-code-review] geolocation: Add sample config file (asterisk[development/16/geolocation])

[Joshua Colp]

Attention is currently required from: George Joseph.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18015 )

Change subject: geolocation:  Add sample config file
......................................................................


Patch Set 1:

(5 comments)

File configs/samples/geolocation.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18015/comment/be8f2105_4422f737 
PS1, Line 17:   - Location information specified in Geographic Markup Langiage (GML),
Specify this is optional.


https://gerrit.asterisk.org/c/asterisk/+/18015/comment/4ecc223d_0676afee 
PS1, Line 20:   - URIs that point to externally hosted location information.
Specify this is optional.


https://gerrit.asterisk.org/c/asterisk/+/18015/comment/30b95161_2508c1db 
PS1, Line 28: UAC).
I'd expand this further, "to control behavior in each direction and to optionally specify location information"


https://gerrit.asterisk.org/c/asterisk/+/18015/comment/6122cf9b_b7be8769 
PS1, Line 37: Must be "profile" to identify this configuration section as a location
Since this configuration doesn't actually require location information (for example in the case of having a profile for an outgoing call to a local endpoint) I'm not sure we should refer to it as a location profile. It's more of a configuration profile.


https://gerrit.asterisk.org/c/asterisk/+/18015/comment/9dbbd761_01e51a3b 
PS1, Line 67: which the location information will be placed.
Should we document that if communicating with an upstream provider, to talk to them in regards to what they expect?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18015
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: Ieb809ed5f843c64528f00a3f08493f24cf4f0ee5
Gerrit-Change-Number: 18015
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Tue, 15 Feb 2022 14:13:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220215/6c0c0d20/attachment.html>