[Asterisk-code-review] res_stir_shaken: refactor utility functions (asterisk[16])

[Sean Bright]

Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17961 )

Change subject: res_stir_shaken: refactor utility functions
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File res/res_stir_shaken/curl.c:

https://gerrit.asterisk.org/c/asterisk/+/17961/comment/122987cf_160ee981 
PS2, Line 174: 	fd = ast_create_temp_file(path, &tmp_filename, template_name);
Why wouldn't ast_file_mkftemp(...) work here?

 if (ast_asprintf(&tmp_filename, "%s/certXXXXXX", path) < 0) {
    return NULL;
 }

 public_key_file = ast_file_mktemp(file_template, 0644);

Plus doing it this way means you wouldn't need to do the fdopen(...).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17961
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ife478708c8f2b127239cb73c1755ef18c0bf431b
Gerrit-Change-Number: 17961
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 14 Feb 2022 16:53:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220214/34426866/attachment.html>