[Asterisk-code-review] app_queue: Add QueueWithdrawCaller AMI action (asterisk[16])

[Joshua Colp]

Attention is currently required from: Kfir Itzhak.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18008 )

Change subject: app_queue: Add QueueWithdrawCaller AMI action
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

Patchset:

PS4: 
The CHANGES entry is not present in this, did you add it?


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/18008/comment/b5d7023b_f56eb454 
PS4, Line 7689: 					qe->withdraw_info = ast_strdup(withdraw_info);
Add a comment that it is impossible for withdraw_info to already be set as only a single withdraw request can occur.


https://gerrit.asterisk.org/c/asterisk/+/18008/comment/a6794339_28a5a32a 
PS4, Line 8797: 	if (qe.withdraw_info != NULL) {
We just use if (qe.withdraw_info) {



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18008
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic15aa238e23b2884abdcaadff2fda7679e29b7ec
Gerrit-Change-Number: 18008
Gerrit-PatchSet: 4
Gerrit-Owner: Kfir Itzhak <mastertheknife at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kfir Itzhak <mastertheknife at gmail.com>
Gerrit-Comment-Date: Mon, 14 Feb 2022 11:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220214/406e83d3/attachment.html>