[Asterisk-code-review] taskprocessor.c: Prevent crash on graceful shutdown (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Michael Bradeen, Benjamin Keith Ford.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17955 )

Change subject: taskprocessor.c: Prevent crash on graceful shutdown
......................................................................


Patch Set 7: Code-Review+1

(2 comments)

Patchset:

PS7: 
This can be cherry picked now


File main/taskprocessor.c:

https://gerrit.asterisk.org/c/asterisk/+/17955/comment/52122bad_7b07e89f 
PS5, Line 298: 	/* During shutdown there may still be taskprocessor threads running and those
             : 	 * tasprocessors reference tps_singletons.  When those taskprocessors finish
             : 	 * they will call ast_taskprocessor_unreference, creating a race condition which
             : 	 * can result in tps_singletons being referenced after being deleted. To try and
             : 	 * avoid this we check the container count and if greater than zero, give the
             : 	 * running taskprocessors a chance to finish */
> This idea of killing the taskprocessor is appealing, but it seems that each module doesn't do the cl […]
Something to keep in mind for a future date if problems continue then.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17955
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia932fc003d316389b9c4fd15ad6594458c9727f1
Gerrit-Change-Number: 17955
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Fri, 11 Feb 2022 16:51:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Michael Bradeen <mbradeen at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220211/23be83ad/attachment-0001.html>