[Asterisk-code-review] curl, res_stir_shaken: refactor utility functions (asterisk[master])

[Mark Murawski]

Attention is currently required from: Sean Bright, N A, Joshua Colp, George Joseph.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17708 )

Change subject: curl, res_stir_shaken: refactor utility functions
......................................................................


Patch Set 7:

(2 comments)

File funcs/func_curl.c:

https://gerrit.asterisk.org/c/asterisk/+/17708/comment/013320e2_e00cee35 
PS7, Line 663: ast_contains_cr_lf
Notate that the reason for this check is regarding CVE-2014-8150 

Put original note regarding CVE-2014-8150 as part of the comments for acf_curl_helper()

Since you're modifying acf_curl_helper... do some boyscouting and add doxygen comments regarding the parameters and retval for acf_curl_helper()


https://gerrit.asterisk.org/c/asterisk/+/17708/comment/3b386d0f_b5c9b28a 
PS7, Line 906: #ifdef TEST_FRAMEWORK
Notate that the reason for this check is CVE-2014-8150



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17708
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ife478708c8f2b127239cb73c1755ef18c0bf431b
Gerrit-Change-Number: 17708
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Mark Murawski <markm at intellasoft.net>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 17:50:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220204/fed6254d/attachment.html>