[Asterisk-code-review] app_mf: Add max digits option to ReceiveMF. (asterisk[master])

[N A]

Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17941 )

Change subject: app_mf: Add max digits option to ReceiveMF.
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17941/comment/97c9c64e_f7c7f0e0 
PS2, Line 7: app_mf: Add max digits option to ReceiveMF
> There _should_ be a period at the end of this line according to commit guidelines, but we're not con […]
Looking back through most commits, it seems the vast majority (90%+) don't end with a period on the subject line, but I did find this in the Coding Guideline, so, eh, not sure what to say.

I've added the period since that's technically right, but not sure what's up with the period if nobody's really using it.


https://gerrit.asterisk.org/c/asterisk/+/17941/comment/82be3f27_04068288 
PS2, Line 9: Adds an option to the ReceiveMF application
           : to allow specifying a maximum number of digits.
           : 
           : Originally, this capability was not added
           : to ReceiveMF as it was with ReceiveSF because
           : typically a ST digit is used to denote that
           : sending of digits is complete. However, there
           : are certain signaling protocols which simply
           : transmit a digit (such as Expanded In-Band
           : Signaling) and for these, it's necessary to
           : be able to read a certain number of digits,
           : as opposed to until receiving a ST digit.
           : 
           : This capability is added as an option, as
           : opposed to as a parameter, to remain
           : compatible with existing usage (and not
           : shift the parameters).
> This is super tight wrapping. Shoot for 72 columns. […]
Yeah, sorry about that... unlike code, I write the commit messages in the terminal directly and nano doesn't provide a char count. I'll keep this trick in mind in the future.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17941
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4229167c9aa69b87402c3c2a9065bd8dfa973a0b
Gerrit-Change-Number: 17941
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 23:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220201/0d7ca167/attachment.html>