[Asterisk-code-review] chan_dahdi: allow audio to pass during call setup phase (asterisk[18])

[N A]

Attention is currently required from: Sarah Autumn, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17948 )

Change subject: chan_dahdi: allow audio to pass during call setup phase
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS4: 
> I have a feelings-based question. […]
Generally speaking, options probably never hurt, so that existing behavior can be preserved when possible. There are a lot of things in Asterisk and DAHDI that are "incorrect", but generally it's desired to maintain backwards-compatibility even when addressing those.

A global on/off in DAHDI and then per-channel in Asterisk sounds reasonable to me, personally. A lot of things require coordination in both places already so I'm not sure I'd be too worried about that...

Just my opinion though...

The DAHDI team does not use Gerrit unfortunately and will not see your comment here, and is quite incommunicado it seems these days, but if you post a patch on a DAHDI issue in JIRA, someone from that team might comment on it at that point?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17948
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibcef6e21020ab6e64f16f4761ec1e0e7fce9c260
Gerrit-Change-Number: 17948
Gerrit-PatchSet: 5
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 22:54:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220201/bb02b0e4/attachment-0001.html>