[Asterisk-code-review] chan_dahdi: allow audio to pass during call setup phase (asterisk[18])

[Sarah Autumn]

Attention is currently required from: N A, Kevin Harwell.
Sarah Autumn has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17948 )

Change subject: chan_dahdi: allow audio to pass during call setup phase
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
I have a feelings-based question. In order for this feature to even work in Asterisk, it requires separate modifications to /etc/dahdi/system.conf and /etc/asterisk/chan_dahdi.conf (not to mention an upcoming patch to the DAHDI kernel driver), should this just be "always on" in DAHDI, and then configurable per channel in Asterisk? 

I guess I'm trying to figure out if it's better to have to configure the same thing in two config files, or to leave it "always on" in one piece of software and have it turn on/off-able in Asterisk. 

I guess channels are configured twice--once in DAHDI and once in Asterisk, so doing it twice would just be par-for-the-course?

The bottom line is that audio cut through on analog channels should be immediate, because thats how the analog network works, and DAHDI's decision to make it not that way seemed arbitrary from the very start, back when it was still Zaptel.

Maybe these are questions better asked of the DAHDI team?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17948
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ibcef6e21020ab6e64f16f4761ec1e0e7fce9c260
Gerrit-Change-Number: 17948
Gerrit-PatchSet: 4
Gerrit-Owner: Sarah Autumn <sarah at endlesstemple.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 19:15:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220201/3ecf3f12/attachment-0001.html>