[Asterisk-code-review] res_http_media_cache: Introduce options and customize (asterisk[20])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, Holger Hans Peter Freyther.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Introduce options and customize
......................................................................


Patch Set 4:

(5 comments)

File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/d34b029b_20a76fdb 
PS3, Line 43: 				<configOption name="useragent">
> user_agent
Done


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/b8b97fee_6f534b3c 
PS3, Line 46: 				<configOption name="followlocation" default="1">
> follow_location
Done


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/8223e6a5_6bbac8f0 
PS3, Line 49: 				<configOption name="maxredirects" default="8">
> max_redirects
Done


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/7cda0e8a_c864a367 
PS3, Line 58: 				<configOption name="redir_protocols">
> redirect_protocols (or something else more descriptive)
Done


File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/d139ca0f_92e61526 
PS4, Line 461: 	curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, !!cfg->general->curl_followlocation);
I think this is okay, though cfg->general->curl_followlocation ? 1 : 0 might be slightly more readable. This seems fine to me though.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 4
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 13:58:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221216/918830a9/attachment.html>