[Asterisk-code-review] app_mixmonitor: Close stream if playing beep failed (asterisk[19.5])

[Sean Bright]

Attention is currently required from: Julien Alie.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19040 )

Change subject: app_mixmonitor: Close stream if playing beep failed
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
There are dozens of places where we call ast_stream_and_wait() throughout the code and don't check its return value, so would it be more appropriate to make this change inside of ast_stream_and_wait() instead of at each call site?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19040
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 19.5
Gerrit-Change-Id: Ib3e4994766f825d5de943c81331ff3c5c23fb189
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Alie <jalie at wazo.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Julien Alie <jalie at wazo.io>
Gerrit-Comment-Date: Wed, 31 Aug 2022 18:39:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220831/9c62c687/attachment.html>