[Asterisk-code-review] pjsip: Add TLS transport reload support for certificate and key. (asterisk[16])

[Sean Bright]

Attention is currently required from: Joshua Colp.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18987 )

Change subject: pjsip: Add TLS transport reload support for certificate and key.
......................................................................


Patch Set 2:

(3 comments)

File res/res_pjsip/config_transport.c:

https://gerrit.asterisk.org/c/asterisk/+/18987/comment/99553b64_58db05af 
PS1, Line 603:                 }
> Leading whitespace.
Done


https://gerrit.asterisk.org/c/asterisk/+/18987/comment/d2dba447_a338ccf4 
PS1, Line 797: 		ast_log(LOG_ERROR, "Failed to stat certificate file '%s' for transport '%s'\n",
             : 				var->value, ast_sorcery_object_get_id(obj));
> stat() sets errno, so throw in a strerror() here?
Done


https://gerrit.asterisk.org/c/asterisk/+/18987/comment/69f62e51_89f51f5e 
PS1, Line 808: 		ast_log(LOG_ERROR, "Failed to stat private key file '%s' for transport '%s'\n",
             : 				var->value, ast_sorcery_object_get_id(obj));
> stat() sets errno, so throw in a strerror() here?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18987
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I9bc95a6bf791830a9491ad9fa43c17d4010028d0
Gerrit-Change-Number: 18987
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 25 Aug 2022 16:26:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220825/3b1aba9c/attachment.html>