[Asterisk-code-review] res_pjsip_logger: Add method-based logging option. (asterisk[master])

[Alexei Gradinari]

Attention is currently required from: Sean Bright, N A, Joshua Colp.
Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18824 )

Change subject: res_pjsip_logger: Add method-based logging option.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> > If anyone actually needs this level of filtering, use sngrep instead. […]
I am also for the fact that complex filters should be in the asterisk.
I would also like to see an additional port filter.
This is necessary when there are many endpoints behind the NAT and I want to monitor only one, knowing from which port requests come.

There are disadvantages of sngrep:
 - on multi bonding interfaces I have to indicate what interface use for captuning or I get duplicate packets.
 - if I use a port bpf filter (sngrep port 5060), the fragmented UDP packets may be filtered by libpcap so sngrep doesn't show them. For example the large RLS NOTIFY.

The asterisk logs what's the asterisk actually receives (after all processing by system) or sends (before processing by system).
So it's what we interested in.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Idd03bd9b466b40e4bca7769437d52ac13a957cf9
Gerrit-Change-Number: 18824
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 19 Aug 2022 13:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220819/f8ad5890/attachment.html>