[Asterisk-code-review] res_pjsip: Add mediasec capabilities. (asterisk[16])

[Maximilian Fridrich]

Attention is currently required from: Joshua Colp, N A.
Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18837 )

Change subject: res_pjsip: Add mediasec capabilities.
......................................................................


Patch Set 6:

(1 comment)

File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/f4556afa_00375bbb 
PS5, Line 1086: 					ast_sip_header_to_security_mechanism(&endpt->server_security_mechanisms, header);
> Endpoints are immutable and may be ephemeral. You can not modify them or store state on them. […]
Good to know. I have gone back to the initial approach using contact_status and made some significant improvements regarding your question "What happens if there are multiple AORs and contacts?".

When an outbound registration receives the security mechanism list from the UAS, it stores the mechanisms in every contact of every AOR associated with the endpoint. Which sounds like a lot but I think in practice there should always only be a handful of AORs and contacts per endpoint.

On subsequent outgoing requests the very first contact which has a security mechanism list is chosen which shouldn't cost too much computationally.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18837
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia7f5b5ba42db18074fdd5428c4e1838728586be2
Gerrit-Change-Number: 18837
Gerrit-PatchSet: 6
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 17:49:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220818/0e811b2b/attachment.html>