[Asterisk-code-review] res_geolocation: Add built-in profiles (asterisk[16])

George Joseph asteriskteam at digium.com
Wed Aug 17 08:17:44 CDT 2022


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/18977

to look at the new patch set (#3).

Change subject: res_geolocation:  Add built-in profiles
......................................................................

res_geolocation:  Add built-in profiles

The trigger to perform outgoing geolocation processing is the
presence of a geoloc_outgoing_call_profile on an endpoint. This
is intentional so as to not leak location information to
destinations that shouldn't receive it.   In a totally dynamic
configuration scenario however, there may not be any profiles
defined in geolocation.conf.  This makes it impossible to do
outgoing processing without defining a "dummy" profile in the
config file.

This commit adds 4 built-in profiles:
  "<prefer_config>"
  "<discard_config>"
  "<prefer_incoming>"
  "<discard_incoming>"
The profiles are empty except for having their predecence
set and can be set on an endpoint to allow processing without
entries in geolocation.conf.  "<discard_config>" is actually the
best one to use in this situation.

ASTERISK-30182

Change-Id: I1819ccfa404ce59802a3a07ad1cabed60fb9480a
---
M configs/samples/geolocation.conf.sample
A doc/CHANGES-staging/res_geolocation.txt
M res/res_geolocation/geoloc_config.c
3 files changed, 96 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/77/18977/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18977
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1819ccfa404ce59802a3a07ad1cabed60fb9480a
Gerrit-Change-Number: 18977
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220817/b6cfb8f8/attachment.html>


More information about the asterisk-code-review mailing list