[Asterisk-code-review] res_pjsip_pubsub: destroy old subscriptions on RLS update using seria... (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Alexei Gradinari.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18891 )

Change subject: res_pjsip_pubsub: destroy old subscriptions on RLS update using serializer
......................................................................


Patch Set 2:

(1 comment)

File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/c/asterisk/+/18891/comment/b25f46fe_d9a53b43 
PS2, Line 4084: 						if (ast_sip_push_task(sub_tree->serializer, destroy_subscriptions_task, old_root)) {
> This is RLS update which happens in pubsub_on_rx_refresh. […]
The code sets the dialog serializer to sub_tree->serializer, and pubsub_rx_refresh would occur as a result of a SIP request on the dialog. This SIP request would go into the sub_tree->serializer. If that's not happening then there's a fundamental issue with dispatching. I doubt that's the case and would think that this is already happening in the correct serializer.

You didn't attach any backtraces or such, so I can't comment any further from that angle.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18891
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I96582aad3a26515ca73a8460ee6756f56f6ba23b
Gerrit-Change-Number: 18891
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 14:57:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220816/cd2976a3/attachment-0001.html>