[Asterisk-code-review] app_amd: Add option to play audio during AMD. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18974 )

Change subject: app_amd: Add option to play audio during AMD.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

File apps/app_amd.c:

https://gerrit.asterisk.org/c/asterisk/+/18974/comment/bf268148_04adc73b 
PS1, Line 96: 				<para>Is an audio file to play to the caller while AMD is in progress.</para>
Document the behavior if it is both configured in the configuration file, as well as here.


https://gerrit.asterisk.org/c/asterisk/+/18974/comment/d850d495_044565c9 
PS1, Line 201: 	const char *audioFile    = dfltAudioFile;
This is unsafe. A reload could have freed it by the time it is used. If you actually want to support this, then locking has to be done and likely duplication of the string.


File doc/CHANGES-staging/app_amd.txt:

https://gerrit.asterisk.org/c/asterisk/+/18974/comment/721a6474_3a63274f 
PS1, Line 4: now be specified.
can now be specified to the AMD application or configured in the configuration file.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18974
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4af306274552b61b3d9f0883c33f698abd4699b6
Gerrit-Change-Number: 18974
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 11:06:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220816/a7eac874/attachment-0001.html>