[Asterisk-code-review] res_geolocation: Address user issues, remove complexity, plug leaks (asterisk[19])

[George Joseph]

Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/18946

to look at the new patch set (#3).

Change subject: res_geolocation: Address user issues, remove complexity, plug leaks
......................................................................

res_geolocation: Address user issues, remove complexity, plug leaks

* Added processing for the 'confidence' element.
* Added documentation to some APIs.
* removed a lot of complex code related to the very-off-nominal
  case of needing to process multiple location info sources.
* Create a new 'ast_geoloc_eprofile_to_pidf' API that just takes
  one eprofile instead of a datastore of multiples.
* Plugged a huge leak in XML processing that arose from
  insufficient documentation by the libxml/libxslt authors.
* Refactored stylesheets to be more efficient.
* Renamed 'profile_action' to 'profile_precedence' to better
  reflect it's purpose.
* Added the config option for 'allow_routing_use' which
  sets the value of the 'Geolocation-Routing' header.
* Removed the GeolocProfileCreate and GeolocProfileDelete
  dialplan apps.
* Changed the GEOLOC_PROFILE dialplan function as follows:
  * Removed the 'profile' argument.
  * Automatically create a profile if it doesn't exist.
  * Delete a profile if 'inheritable' is set to no.
* Fixed various bugs and leaks
* Updated Asterisk WiKi documentation.

ASTERISK-30167

Change-Id: If38c23f26228e96165be161c2f5e849cb8e16fa0
---
M configs/samples/geolocation.conf.sample
A doc/CHANGES-staging/res_geolocation.txt
M include/asterisk/res_geolocation.h
M include/asterisk/xml.h
M main/xml.c
M res/res_geolocation/eprofile_to_pidf.xslt
M res/res_geolocation/geoloc_config.c
M res/res_geolocation/geoloc_dialplan.c
M res/res_geolocation/geoloc_doc.xml
M res/res_geolocation/geoloc_eprofile.c
M res/res_geolocation/geoloc_gml.c
M res/res_geolocation/geoloc_private.h
M res/res_geolocation/pidf_lo_test.xml
M res/res_geolocation/pidf_to_eprofile.xslt
M res/res_geolocation/wiki/AsteriskImplementation.md
M res/res_pjsip_geolocation.c
16 files changed, 1,119 insertions(+), 1,258 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/46/18946/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18946
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 19
Gerrit-Change-Id: If38c23f26228e96165be161c2f5e849cb8e16fa0
Gerrit-Change-Number: 18946
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220810/afd5e832/attachment-0001.html>