[Asterisk-code-review] res_pjsip: Add TEL URI support for basic calls. (asterisk[16])
Alexei Gradinari
asteriskteam at digium.com
Mon Aug 8 17:20:31 CDT 2022
Attention is currently required from: Benjamin Keith Ford.
Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18892 )
Change subject: res_pjsip: Add TEL URI support for basic calls.
......................................................................
Patch Set 1:
(2 comments)
File res/res_pjsip_pubsub.c:
https://gerrit.asterisk.org/c/asterisk/+/18892/comment/b8f109f4_64693fc0
PS1, Line 3033: if (!PJSIP_URI_SCHEME_IS_SIP(request_uri) && !PJSIP_URI_SCHEME_IS_SIPS(request_uri)) {
why don't use ast_sip_is_allowed_uri?
https://gerrit.asterisk.org/c/asterisk/+/18892/comment/5353b8b1_ebfff3ca
PS1, Line 3266: if (!PJSIP_URI_SCHEME_IS_SIP(request_uri) && !PJSIP_URI_SCHEME_IS_SIPS(request_uri)) {
why don't use ast_sip_is_allowed_uri?
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18892
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If5729e6cd583be7acf666373bf9f1b9d653ec29a
Gerrit-Change-Number: 18892
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Mon, 08 Aug 2022 22:20:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220808/57b1ee36/attachment.html>
More information about the asterisk-code-review
mailing list