[Asterisk-code-review] app_confbridge: Fix bridge shutdown race condition. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Sat Aug 6 17:10:02 CDT 2022


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18577 )

Change subject: app_confbridge: Fix bridge shutdown race condition.
......................................................................


Patch Set 1:

(1 comment)

File apps/app_confbridge.c:

https://gerrit.asterisk.org/c/asterisk/+/18577/comment/d2dd87af_9871fd3b 
PS1, Line 1742: 	conference = ao2_find(conference_bridges, conference_name, OBJ_KEY);
> I think I follow this logic except for one caveat: what about the case where the conference is *not* […]
The lock for the conference bridge would likely need to be held to check it which should ensure that things aren't changing underneath.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18577
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I08a440eafbf83ec4b502d1e44c3f4d44c4a522f9
Gerrit-Change-Number: 18577
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Sat, 06 Aug 2022 22:10:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220806/22f1ed26/attachment-0001.html>


More information about the asterisk-code-review mailing list