[Asterisk-code-review] func_channel: Added new OTHER_CHANNEL function (asterisk[master])
Mark Murawski
asteriskteam at digium.com
Sat Aug 6 15:22:36 CDT 2022
Attention is currently required from: N A, Joshua Colp.
Mark Murawski has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15893 )
Change subject: func_channel: Added new OTHER_CHANNEL function
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> Can you trigger a deadlock when using OTHER_CHANNEL(OTHER_CHANNEL(B_CHANNEL,SomeVar),A_CHANNEL) or s […]
Another item, is consistency. We have CHANNEL() as a function but it doesn't do anything related to what OTHER_CHANNEL is doing.
In terms of naming, we have IMPORT() which reads data from another channel. What about naming this EXPORT() ?
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15893
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf
Gerrit-Change-Number: 15893
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 06 Aug 2022 20:22:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220806/2544d25f/attachment.html>
More information about the asterisk-code-review
mailing list