[Asterisk-code-review] cli: Prevent assertions on startup from bad ao2 refs. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18523 )

Change subject: cli: Prevent assertions on startup from bad ao2 refs.
......................................................................


Patch Set 3:

(1 comment)

File main/cli.c:

https://gerrit.asterisk.org/c/asterisk/+/18523/comment/87a2b167_305b5403 
PS1, Line 1143: 	while (!ast_test_flag(&ast_options, AST_OPT_FLAG_FULLY_BOOTED)) {
> I think the builtins_init should be moved even to be after the ast_cli_perms_init(0); call. […]
This ended up being the best way to do it, I've split the channel related commands off into a separate group that gets loaded later. Some of them do make sense to be loaded earlier, especially things like setting the CLI verbosity, but the channel related commands are moved to after the permissions init.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18523
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6b3cde802876bd738c1b4cf2683bea6ddc615b6
Gerrit-Change-Number: 18523
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <default.enum at gmail.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Sat, 06 Aug 2022 20:01:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <default.enum at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220806/0e67deee/attachment-0001.html>