[Asterisk-code-review] callerid: Fix buggy and missing Caller ID parameters (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18305 )

Change subject: callerid: Fix buggy and missing Caller ID parameters
......................................................................


Patch Set 6:

(2 comments)

Patchset:

PS6: 
whi


File include/asterisk/callerid.h:

https://gerrit.asterisk.org/c/asterisk/+/18305/comment/2445da1f_64ef7565 
PS6, Line 114: int callerid_generate(unsigned char *buf, const char *number, const char *name, const char *ddn, int redirecting,
> This function gets exported, so changing will break the API.
Which is fine if leaving master only. If you're going to cherry pick then this will need to change for the other branches.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18305
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Icc44a5e09979916f4c18a440f96e10dc1c76ae15
Gerrit-Change-Number: 18305
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 21:16:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220428/c50e8b33/attachment-0001.html>