[Asterisk-code-review] ARI channels: exposed channel driver's unique id (which is the Call-I... (asterisk[master])

[Moritz Fain]

Attention is currently required from: Joshua Colp, Kevin Harwell, Richard Mudgett.
Moritz Fain has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18413 )

Change subject: ARI channels: exposed channel driver's unique id (which is the Call-ID for SIP/PJSIP) to ARI channel resource as 'pvt_id'
......................................................................


Patch Set 6:

(1 comment)

File main/stasis_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/18413/comment/4b466361_2277a39b 
PS6, Line 1282: 		"pvt_id", snapshot->base->pvt_uniqueid,
> I'm not a fan of exposing this as pvt_id externally. […]
Fine as well... Or we call it "call_id" and populate it only in case of chan_sip and chan_pjsip? No other channel driver is currently implementing `get_pvt_uniqueid`.

btw: pvt_id is already exposed in "BRIDGEPVTCALLID" variable (not sure why; introduced a decade ago).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7cc6e7a9d29efe74bc27811d788dac20fe559b87
Gerrit-Change-Number: 18413
Gerrit-PatchSet: 6
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 27 Apr 2022 12:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220427/b236f039/attachment.html>