[Asterisk-code-review] ARI channels: exposed channel driver's unique id (which is the Call-I... (asterisk[master])

[Joshua Colp]

Attention is currently required from: Kevin Harwell, Moritz Fain, Richard Mudgett.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18413 )

Change subject: ARI channels: exposed channel driver's unique id (which is the Call-ID for SIP/PJSIP) to ARI channel resource as 'pvt_id'
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

File main/stasis_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/18413/comment/116ebd42_e154c93b 
PS6, Line 1282: 		"pvt_id", snapshot->base->pvt_uniqueid,
I'm not a fan of exposing this as pvt_id externally. Pvt is really an internal Asterisk construct, and details like that should be kept out of ARI as much as possible. protocol_id is probably better to indicate it's an ID relating to the underlying protocol of the channel.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7cc6e7a9d29efe74bc27811d788dac20fe559b87
Gerrit-Change-Number: 18413
Gerrit-PatchSet: 6
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Moritz Fain <moritz at fain.io>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 27 Apr 2022 12:00:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220427/1fdab5ff/attachment-0001.html>