[Asterisk-code-review] ARI channels: exposed channel driver's unique id (which is the Call-I... (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Tue Apr 26 17:14:54 CDT 2022


Attention is currently required from: Kevin Harwell, Moritz Fain.
Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18413 )

Change subject: ARI channels: exposed channel driver's unique id (which is the Call-ID for SIP/PJSIP) to ARI channel resource as 'pvt_id'
......................................................................


Patch Set 6:

(1 comment)

File include/asterisk/stasis_channels.h:

https://gerrit.asterisk.org/c/asterisk/+/18413/comment/325de333_d8d70ca6 
PS6, Line 108: 		AST_STRING_FIELD(pvt_uniqueid);  /*!< Channel drivers unique id */
> Adding the field in this way breaks ABI compatibility. […]
Extended string fields are only necessary on released branches to avoid ABI breakage.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7cc6e7a9d29efe74bc27811d788dac20fe559b87
Gerrit-Change-Number: 18413
Gerrit-PatchSet: 6
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Moritz Fain <moritz at fain.io>
Gerrit-Comment-Date: Tue, 26 Apr 2022 22:14:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220426/a9329ef9/attachment.html>


More information about the asterisk-code-review mailing list