[Asterisk-code-review] features: Add transfer initiation options. (asterisk[master])

[Richard Mudgett]

Attention is currently required from: N A, Kevin Harwell.
Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18001 )

Change subject: features: Add transfer initiation options.
......................................................................


Patch Set 4:

(2 comments)

File include/asterisk/features_config.h:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/49ef662a_364d0ad4 
PS4, Line 76: 		AST_STRING_FIELD(transferannouncesound);
> This breaks ABI. […]
For the master branch you can do any ABI breakage needed.  For released branches you need to avoid ABI breakage.  So for master this is fine, for released branches you need to do the extended method.


File main/features_config.c:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/234cba23_a4efbe90 
PS4, Line 1807: 	aco_option_register_custom(&cfg_info, "transferannouncesound", ACO_EXACT, global_options,
> ast_string_field_init_extended(&cfg_info, transferannouncesound); will be needed here
Only for released branches where extended string fields are necessary to avoid ABI breakage.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18001
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3
Gerrit-Change-Number: 18001
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 26 Apr 2022 22:12:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220426/df15785f/attachment.html>