[Asterisk-code-review] res_pjsip_stir_shaken.c: Fix enabled when not configured. (asterisk[16])
Joshua Colp
asteriskteam at digium.com
Tue Apr 26 09:39:21 CDT 2022
Attention is currently required from: Benjamin Keith Ford.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18414 )
Change subject: res_pjsip_stir_shaken.c: Fix enabled when not configured.
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File res/res_pjsip_stir_shaken.c:
https://gerrit.asterisk.org/c/asterisk/+/18414/comment/5f4e68ea_9c7be4ac
PS1, Line 231: if ((profile && !ast_stir_shaken_profile_supports_verification(profile))
I think a comment should be added to both of these describing the logic, to prevent any future confusion and be explicit about it.
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18414
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I41286a3d35b033ccbfbe4129427a62cb793a86e6
Gerrit-Change-Number: 18414
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Friendly Automation
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Tue, 26 Apr 2022 14:39:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220426/35346061/attachment-0001.html>
More information about the asterisk-code-review
mailing list