[Asterisk-code-review] res_geolocation: Add initial markdown for Geolocation wiki pages (asterisk[development/16/geolocation])

[N A]

Attention is currently required from: Joshua Colp, George Joseph, Kevin Harwell.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18360 )

Change subject: res_geolocation:  Add initial markdown for Geolocation wiki pages
......................................................................


Patch Set 2: Code-Review-1

(8 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/2913f75b_4fd752d5 
PS2, Line 10: since I'm going to be offline for a bit.
Is this commit message still accurate? Either way I feel the last sentence should be replaced with something more substantive about the commit itself.


File res/res_geolocation/wiki/AsteriskImplementation.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/18580c3a_e3d95900 
PS2, Line 65: See [RFC6442|Geolocation#rfc6442] for more informatrion.|
information


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/a225bb71_aaf31b21 
PS2, Line 134: You'll notice that neither bob nor alice set {{geoloc_outging_call_profile}} because we never want to send location information _to_ them.
outgoing


File res/res_geolocation/wiki/CivicAddress.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/ab906075_616a2296 
PS2, Line 1: {toc}
Missing new line at EOF


File res/res_geolocation/wiki/GML.md:

PS2: 
Is this file supposed to be empty?


File res/res_geolocation/wiki/URI.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/f5ca7ccf_45d9019d 
PS2, Line 10: Passing location descriptions using URIs is fairly simple from an Asterisk perspective.  It does however, require the implementer to establish and maintain infrastructure to handle the serving of those URIs.  Given the critical nature of the information, setting up such infrasstructure is not trivial and is beyond the scope of Asterisk and this documentation.
infrastructure


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/67e36a88_de12d4c1 
PS2, Line 39: Now let's say that Bob has DID {{12125551212}} assigned to him and he makes an outgoping call which is routed to "my-provider".  Asterisk would automatically add the following header to the INVITE:
outgoing, not outgoping


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/9c04ed48_8d21b196 
PS2, Line 45: Of course, this is a _very_ simple example that would add the Geolocation header to _all_ calls made via "my-provider".  If you oonly routed emergency calls to "my-provider" this would work fine but you probably don't want to leak location information on non-emergency calls.
only



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18360
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I85b239776209bff3fc3388cf9b0a322a1764db29
Gerrit-Change-Number: 18360
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 16:42:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220419/332961f7/attachment-0001.html>