[Asterisk-code-review] app_read: Fix null pointer crash (asterisk[master])
Joshua Colp
asteriskteam at digium.com
Wed Sep 29 13:25:21 CDT 2021
Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16562 )
Change subject: app_read: Fix null pointer crash
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> That's correct. It's triggered by specifying t with no arguments, that is, removing the terminator. […]
Are you sure of this? Reading the code and what you've fixed, I believe this occurs if the 't' option is not specified at all and the 'i' option is used. By default terminator is set to NULL in that case. If the 't' option is specified then it gets set to either the value, or if empty then "".
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16562
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie941833e123c3dbfb88371b5de5edbbe065514ac
Gerrit-Change-Number: 16562
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 18:25:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210929/2ca8e6d2/attachment.html>
More information about the asterisk-code-review
mailing list