[Asterisk-code-review] main/say.c: Support future dates with Q and q format params (asterisk[master])

Shloime Rosenblum asteriskteam at digium.com
Mon Sep 27 03:31:18 CDT 2021


Attention is currently required from: Sean Bright, Joshua Colp, Kevin Harwell.
Shloime Rosenblum has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16517 )

Change subject: main/say.c: Support future dates with Q and q format params
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> Maybe this is good enough as this patch has it (for now at least), but while this patch adds future  […]
When you write your dialplan you know most of the time what you expect and you play 'was' or 'will be' but it is a good point. Maybe adding the date number like 'Wednesday the 6th' is something to consider.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16517
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1fb1cef0ce3c18d87b1fc94ea309d13bc344af02
Gerrit-Change-Number: 16517
Gerrit-PatchSet: 2
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 27 Sep 2021 08:31:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210927/f6255483/attachment-0001.html>


More information about the asterisk-code-review mailing list