[Asterisk-code-review] tests/pjsip/config_options/remove_unavailable: Test new config option (testsuite[master])

[Kevin Harwell]

Attention is currently required from: Joe.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/16491 )

Change subject: tests/pjsip/config_options/remove_unavailable: Test new config option
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File tests/channels/pjsip/registration/inbound/nominal/config_options/remove_unavailable/sipp/register-ipv4-remove-existing-enabled.xml:

https://gerrit.asterisk.org/c/testsuite/+/16491/comment/9ba8e821_6e0cbd7b 
PS3, Line 73: 			<ereg regexp="Contact: <sip:(charlie|carol)-2 at 127.0.0.3:5063>;expires=(60|5[5-9])" search_in="msg" check_it="true" assign_to="4"/>
Should this contact not have been the one removed vs. the one at 127.0.0.2:5062? None are reachable, but this contact expires before the one registered at 127.0.0.2:5062.


File tests/channels/pjsip/registration/inbound/nominal/config_options/remove_unavailable/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/16491/comment/d16fec6b_74475a43 
PS3, Line 56:                 - { 'key-args': {'scenario': 'register-ipv4-remove-existing-enabled.xml', '-i': '127.0.0.1', '-p': '5161', '-s': 'carol'} }
Are you still getting the "Unable to bind main socket, errno = 98 (Address already in use)." error? I misread your comment on the main patch review. I thought you meant you were trying to run the full testsuite (all tests), but you just meant the scenarios here in your one test.

This appears here to use the same ip/port as the first UDP IPv4 scenario, so I'd expect the the "address already in use" error here when this scenario attempts to launch.

You can either use another port, or a different local IP.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16491
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: I336bd2bac512396b33407882066a8ec66a914f5c
Gerrit-Change-Number: 16491
Gerrit-PatchSet: 3
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joe <ynadiv at corpit.xyz>
Gerrit-Comment-Date: Tue, 21 Sep 2021 19:58:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210921/19bee421/attachment.html>