[Asterisk-code-review] res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Sean Bright, George Joseph, Joe.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16160 )

Change subject: res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts
......................................................................


Patch Set 11:

(2 comments)

Patchset:

PS10: 
> Actually, for all my complaining, the test I wrote actually seems to work and I've found a bug.

I have been there many times :-) At least hopefully it makes all your effort feel more worthwhile. And thanks for putting in the effort. I know setting up the testsuite and writing a test is a bit daunting the first time.

Know too the test you've written now may also catch future bugs if/when someone modifies the code in or around this feature, or has to modify the feature itself for some reason.


PS10: 
> Unable to bind main socket, errno = 98 (Address already in use).

That's a timing issue (kinda a bug) where a previous test's socket is not released in time for the next test. Then the next test attempts to obtain the same address, and you get that error.

At least that is what appeared to be happening last I saw similar. However I thought it had been fixed.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16160
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia2711b08f2b4d1177411b1be23e970d7fdff5784
Gerrit-Change-Number: 16160
Gerrit-PatchSet: 11
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Joe <ynadiv at corpit.xyz>
Gerrit-Comment-Date: Mon, 20 Sep 2021 16:28:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210920/c29d75c5/attachment.html>