[Asterisk-code-review] app_mf: Add full MF/SF support (asterisk[master])

[George Joseph]

Attention is currently required from: N A.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16481 )

Change subject: app_mf: Add full MF/SF support
......................................................................


Patch Set 4: Code-Review-2

(1 comment)

Patchset:

PS4: 
-2 for several reasons...
1.  I haven't heard SF signalling since the '80s and SF over SIP??  Unless you actually have a real use case where it needs to be supported, SF support should be removed.

2.  This review and your other MF review both create app_mf.c which isn't going to work.  If you just add another commit to your other review's branch and do a "git review", it'll confirm with you that you want to submit two reviews and Gerrit is smart enough to leave the original review alone and create a new review with the other one as the parent.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16481
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I05ba61ce49092d3f131ade9dc4d97dcc9887fa1d
Gerrit-Change-Number: 16481
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 13 Sep 2021 15:24:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210913/58c8521a/attachment.html>