[Asterisk-code-review] res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_N... (asterisk[18])

[Joshua Colp]

Attention is currently required from: George Joseph, Mark Petersen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16344 )

Change subject: res_pjsip_rfc3326: Q.850 reason code for CANCEL is set to AST_CAUSE_NORMAL_CLEARING
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

File res/res_pjsip_rfc3326.c:

https://gerrit.asterisk.org/c/asterisk/+/16344/comment/af57427e_31ed2c2c 
PS1, Line 108: 		if (ast_channel_hangupcause(session->channel) == AST_CAUSE_NOTDEFINED) {
> we have now change the if to only apply when it also is a pjsip_cancel_method
I would also like to know the reason that the hangup cause is not being defined. It feels like this may be working around a problem elsewhere. At the very least I think the situation should be documented where it occurs.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16344
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ib653aec2282f55b59d87484391cc07c8e6612b89
Gerrit-Change-Number: 16344
Gerrit-PatchSet: 3
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Wed, 08 Sep 2021 11:11:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210908/b5b55eed/attachment.html>