[Asterisk-code-review] app_assert: Add Assert application (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16629 )

Change subject: app_assert: Add Assert application
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> Regarding your latter comments, the goal of this Assert() application is indeed for "this should nev […]
Okay I'll concede it can be used in such a manner, and in that sense would be similar to a general progrmaming assert. I still contend though that unlike regular asserts there is no way to disable such checks once verified, and the code is set for production (aside from manual deletion). If left in I don't see really any difference between the assert and regular error handling. And for that matter I also don't understand the useful of the 'd' option. Seems like you just have a LogIf at that point.

Not saying a few keystrokes aren't saved with this function, and one could argue readability is increased, but maybe the name could be seen as slightly misrepresentative. Perhaps 'ErrorIf' with a hangup option would be better? I think that might make it easier to understand to the general diaplan writer, and help more convey its usefulness.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16629
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia089c2debf608f42f5f87e6c29d50e8ebcc093e5
Gerrit-Change-Number: 16629
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Mon, 25 Oct 2021 22:00:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211025/be5fc566/attachment.html>